v4.0.x: hwloc: clarify --with-hwloc behavior #7254
Merged
+21
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify in README what --with-hwloc does in its different use cases. Also, ensure that the behavior when specifying `--with-hwloc` is the same as if that option is not specified at all. This is what we did in Open MPI <= v3.x; looks like we inadvertantly caused `--with-hwloc` to be synonymous with `--with-hwloc=external` in v4.0.0. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 18c3e1a)
hppritcha
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify in README what --with-hwloc does in its different use cases.
Also, ensure that the behavior when specifying
--with-hwlocis thesame as if that option is not specified at all. This is what we did
in Open MPI <= v3.x; looks like we inadvertantly caused
--with-hwlocto be synonymous with
--with-hwloc=externalin v4.0.0.Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit 18c3e1a)
Thanks to @marmistrz on #6501 for the heads-up on this issue.